Eventual BG with 1 decimal in the app and in the watch app #320
Conversation
- Use `targetFormatter` instead of `numberFormater` for `eventualBG` in the app, since this has the appropriate `maximumFractionDigits = 1` - Change eventualFormatter to use `maximumFractionDigits = 1` instead of `2` on the watch
bjornoleh
requested review from
dnzxy,
MikePlante1,
aug0211,
AndreasStokholm,
Sjoerd-Bo3 and
t1dude
as code owners
|
Eventual BG as presented with this patch: 52,8 mmol/L to the left, 951 mg/dL to the right (random numbers from sim phone/watch/CGM and pump) |
|
@bjornoleh there is a glucoseformatter also in ./FreeAPS/Sources/Modules/Home/View/Header/CurrentGlucoseView.swift which should fit perfectly for this issue |
Thanks for looking! That is in another file, right? I don't think that |
Totally! As per discussion of targets and rounding errors leading to changed targets after multiple unit switches, I suspect that using would not lead to these. I think @polscm32 already centralized all formatters in Helpers at one point in some branch, which I guess is something we should also do. It only popped into my mind when viewing this PR as there are some inconsistencies in how rT.variables are handed over from oref to swift. Some are "convert_bg functioned" some always in md/dL - I think I am partly responsible for that and started fixing it, so I stumbled across glucoseformatter just this week. |
|
@mountrcg , perhaps you can write up an issue about this for later? |
Use
targetFormatterinstead ofnumberFormaterforeventualBGin the app, since this has the appropriatemaximumFractionDigits = 1Change eventualFormatter to use
maximumFractionDigits = 1instead of2on the watchResolves #319